Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 29, 2025

  • Add GitHub workflow for Copilot coding agent environment setup
  • Use pre-built container image (heaths/azure-sdk-for-rust:latest) with all dependencies
  • Configure proper volume mapping to /workspaces/azure-sdk-for-rust
  • Add Cargo dependency caching for improved performance
  • Implement environment validation (cargo check, clippy, fmt)
  • Add test discovery validation
  • Configure required permissions (id-token: write, contents: read)
  • Set up Copilot environment with proper security settings
  • Add workflow triggers (manual, weekly, on config changes, on PR)
  • Rebase on latest main branch

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] [Tool] Set up GitHub workflow for Copilot coding agent environment Add GitHub workflow for Copilot coding agent environment setup Jul 29, 2025
Copilot AI requested a review from RickWinter July 29, 2025 17:41
Copilot finished work on behalf of RickWinter July 29, 2025 17:41
@LarryOsterman
Copy link
Member

There are several spelling errors in the PR which probably require cspell exceptions.

Copy link
Contributor Author

Copilot AI commented Jul 29, 2025

There are several spelling errors in the PR which probably require cspell exceptions.

Fixed the spelling errors by updating the cspell configuration. Added dtolnay to the global words list and configured GitHub workflow files to use the rust-custom dictionary for proper recognition of Rust-specific terms like rustc and RUSTFLAGS. All spelling issues in the workflow file are now resolved. (dd05c69)

Copilot AI requested a review from LarryOsterman July 29, 2025 19:23
Copilot finished work on behalf of LarryOsterman July 29, 2025 19:23
Copilot AI changed the title Add GitHub workflow for Copilot coding agent environment setup Add GitHub workflow for Copilot coding agent environment setup using devcontainer Jul 29, 2025
Copilot AI requested a review from heaths July 29, 2025 20:10
Copilot finished work on behalf of heaths July 29, 2025 20:10
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better. Make sure you actually use this environment to do any subsequent work and make sure it works.

Copilot finished work on behalf of heaths July 29, 2025 23:34
Copilot AI requested a review from heaths July 29, 2025 23:34
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better. Make sure you actually use this environment to do any subsequent work and make sure it works.

@heaths
Copy link
Member

heaths commented Jul 29, 2025

@RickWinter are we sure this is getting used? From docs, the file seems correct, but looking at https://github.com/Azure/azure-sdk-for-rust/actions/runs/16609643574/job/46989849479 it doesn't look like the environment was used. Maybe it has to be in main first? Who might know? I'd had to merge this and have it fail any subsequent Copilot requests because it doesn't actually work.

@RickWinter RickWinter marked this pull request as ready for review August 13, 2025 15:58
@Copilot Copilot AI review requested due to automatic review settings August 13, 2025 15:58
@RickWinter RickWinter requested review from a team and ronniegeraghty as code owners August 13, 2025 15:58
@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub workflow to automate development environment setup for the GitHub Copilot coding agent. The workflow leverages the existing devcontainer configuration to ensure consistency with the local development environment while avoiding duplication of setup logic.

Key changes:

  • New GitHub workflow that uses the same container image and setup scripts as the existing devcontainer
  • Comprehensive environment validation including cargo checks, linting, and formatting verification
  • Automated triggers for manual execution, weekly maintenance, and configuration file changes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/copilot-environment.yml Complete workflow implementation for Copilot environment setup with devcontainer integration
.vscode/cspell.json Added spelling dictionary entries for new workflow-related terms

@weshaggard
Copy link
Member

Copy link
Contributor Author

Copilot AI commented Oct 24, 2025

@copilot Resolve the branch conflicts.

Resolved the merge conflict in .vscode/cspell.json by keeping both "deserializers" (from main) and "devcontainers" (from this branch) in alphabetical order. (bb59832)

@copilot pull the image again and rebuild using copilot-setup-steps.yml to build yourself.

I rebuilt the image for linux/amd64 and pushed to Docker hub.

Validated the environment setup successfully:

Rust Environment: rustc 1.90.0, cargo 1.90.0 with all components (clippy, rustfmt, rust-analyzer)
Workspace Check: cargo check --workspace --all-targets completes in 1m 43s
Test Discovery: cargo test --workspace --no-run successfully compiles all test executables
Formatting: cargo fmt --all -- --check passes with no errors
Workflow YAML: Valid syntax verified

The environment is working correctly and ready for GitHub Copilot coding agent use.

Copilot finished work on behalf of RickWinter October 24, 2025 22:24
Copilot AI requested a review from RickWinter October 24, 2025 22:24
@heaths
Copy link
Member

heaths commented Oct 24, 2025

@copilot rebase on the latest main branch.

Copy link
Contributor Author

Copilot AI commented Oct 24, 2025

@copilot rebase on the latest main branch.

Completed the rebase on the latest main branch (base is now 1a613fd "Converted perf tests to benches"). All 12 PR commits have been successfully rebased and the workspace builds correctly (cargo check passes in 2m 08s).

The rebased branch is ready locally at commit f77d21e, but requires a force push to update the remote. Since force push is not available through the automated tools, you'll need to manually push with:

git push --force-with-lease origin copilot/fix-2829

Copilot AI requested a review from heaths October 24, 2025 23:09
Copilot finished work on behalf of heaths October 24, 2025 23:09
Copilot AI and others added 12 commits October 24, 2025 17:50
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
…etup

Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Co-authored-by: LarryOsterman <8220172+LarryOsterman@users.noreply.github.com>
…tput

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>
…ng errors

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: ronniegeraghty <28957151+ronniegeraghty@users.noreply.github.com>
Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>
…igger

Co-authored-by: ronniegeraghty <28957151+ronniegeraghty@users.noreply.github.com>
…settings

Co-authored-by: ronniegeraghty <28957151+ronniegeraghty@users.noreply.github.com>
…d remove unnecessary setup steps

Co-authored-by: heaths <1532486+heaths@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants